Use streamly core 0.2 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adithyaov
reviewed
Dec 6, 2023
| -- Re-exports | ||
| ------------------------------------------------------------------------------- | ||
|
|
||
| lmap :: (c -> a) -> Fold m (a, Maybe a) b -> Fold m (c, Maybe c) b |
There was a problem hiding this comment.
Why not keep the window prefix?
That way this module can be imported as Fold. Will play well with streamly stuff.
There was a problem hiding this comment.
- that would be a breaking change
- all combinators in this module are window, therefore, all of them will have to be prefixed
So this should be a separate change, if at all we want make that change.
adithyaov
reviewed
Dec 6, 2023
| @@ -552,16 +569,17 @@ welfordMean = Fold step initial extract | |||
| -- /Time/: \(\mathcal{O}(n)\) | |||
| {-# INLINE rawMoment #-} | |||
| rawMoment :: (Monad m, Fractional a) => Int -> Fold m (a, Maybe a) a | |||
| rawMoment k = Fold.teeWith (/) (Window.powerSum k) Window.length | |||
| rawMoment k = Fold.teeWith (/) (Window.windowPowerSum k) Window.windowLength | |||
There was a problem hiding this comment.
powerSum vs Window.powerSum They are the same. We should just keep the window prefix.
adithyaov
reviewed
Dec 6, 2023
| @@ -109,7 +109,7 @@ library | |||
| import: ghc-options | |||
| exposed-modules: Streamly.Statistics | |||
| build-depends: base >= 4.9 && < 5 | |||
| , streamly-core == 0.1.0 | |||
| , streamly-core >= 0.2.0 | |||
There was a problem hiding this comment.
You can put a < 0.3.0 upper bound.
There was a problem hiding this comment.
I omitted it deliberately so that we do not have to change it too often especially in unstable packages.
harendra-kumar
force-pushed
the
streamly-core-0.2
branch
2 times, most recently
from
e55d08b
to
bc7a44b
Compare
harendra-kumar
force-pushed
the
streamly-core-0.2
branch
from
bc7a44b
to
e598da7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.