Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xeus-cpp dependency from clangdev 16 to 17 #17

Closed

Conversation

anutosh491
Copy link
Collaborator

This PR fixes the make && make install build failures while using clang 17.0.4 and llvm 17.0.4. The main changes here are inspired by (llvm/llvm-project@b8e5f91 and llvm/llvm-project@8b1771b) as
ExecutorAddr was introduced in as an eventual replacement for JITTargetAddress and ExecutorSymbolDef was introduced as a
replacement for JITEvaluatedSymbol in the following patches.

@vgvassilev
Copy link
Contributor

Do you have any clue why things fail on osx?

@JohanMabille
Copy link
Collaborator

JohanMabille commented Nov 8, 2023

We probably need to use clang 17 rather than cxx-compiler which pulls clang 16

@anutosh491
Copy link
Collaborator Author

Looks like clang_osx64 17 is not available yet ( latest is 16.0.6). So we'll maybe have to wait until the switch happens to clang 17 on osx. @vgvassilev

@anutosh491 anutosh491 marked this pull request as draft November 10, 2023 12:40
@anutosh491
Copy link
Collaborator Author

I think clang_osx 17 is now available (conda-forge/clang-compiler-activation-feedstock#113) but we might have to wait for it to be enabled as the default compiler (https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/cbccb41e313c017c1ad15db6c287e87aa57d54dd/recipe/conda_build_config.yaml#L18)

@vgvassilev
Copy link
Contributor

LLVM 17 seems broken. It has valgrind issues discovered by CppInterOp. We should probably not update before fixing them: https://github.com/compiler-research/CppInterOp/actions/runs/7561682890/job/20590508932#step:26:11915

@anutosh491 anutosh491 marked this pull request as ready for review March 25, 2024 11:49
@vgvassilev
Copy link
Contributor

That's not needed anymore. It will be handled on the CppInterOp side. Do you mind closing this one?

@anutosh491
Copy link
Collaborator Author

Yeah sure it makes sense. let's close this for now !

@anutosh491 anutosh491 closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants