-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update xeus-cpp documentation setup #13
Update xeus-cpp documentation setup #13
Conversation
CMakeLists.txt
Outdated
argparse | ||
GIT_REPOSITORY https://github.com/p-ranav/argparse.git | ||
) | ||
FetchContent_MakeAvailable(argparse) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why find_package(argparse ...)
is not sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
I tried fetching cppargparse as well argparse from conda but it did'nt find the dependency,
ResolvePackageNotFound:
- cpp-argparse
leading to the following error
Could not find a package configuration file provided by "argparse" with any
of the following names:
argparseConfig.cmake
argparse-config.cmake
166f74b
to
2d2205f
Compare
CMakeLists.txt
Outdated
# argparse | ||
# GIT_REPOSITORY https://github.com/p-ranav/argparse.git | ||
# ) | ||
# FetchContent_MakeAvailable(argparse) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove that commented out code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
0f243d5
to
3b6d1ee
Compare
Thanks for this work. I think it would be interesting to keep the directory structure that is common with all the xeus-based kernels for the documentation. For example, this broke the link to the logo in the readme. |
@Krishna-13-cyber, could you look into this? @SylvainCorlay, do we have a better place to that documentation? |
I think it is all fine! My comment was merely that moving the source files from This also makes re-generating the cookie-cutter bits harder. |
Hi, |
That would be great - just for keeping the xeus-based kernel as similar as possible where possible. |
Yes, I will get this done. |
No description provided.