Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xeus-cpp documentation setup #13

Merged

Conversation

Krishna-13-cyber
Copy link
Contributor

No description provided.

CMakeLists.txt Outdated
argparse
GIT_REPOSITORY https://github.com/p-ranav/argparse.git
)
FetchContent_MakeAvailable(argparse)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why find_package(argparse ...) is not sufficient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,
I tried fetching cppargparse as well argparse from conda but it did'nt find the dependency,

ResolvePackageNotFound: 
  - cpp-argparse

leading to the following error

Could not find a package configuration file provided by "argparse" with any
of the following names:

  argparseConfig.cmake
  argparse-config.cmake

@Krishna-13-cyber Krishna-13-cyber force-pushed the docs-setup-update branch 2 times, most recently from 166f74b to 2d2205f Compare August 23, 2023 09:10
CMakeLists.txt Outdated
# argparse
# GIT_REPOSITORY https://github.com/p-ranav/argparse.git
# )
# FetchContent_MakeAvailable(argparse)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove that commented out code.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit ae30c4a into compiler-research:main Aug 23, 2023
2 of 8 checks passed
@SylvainCorlay
Copy link
Collaborator

Thanks for this work.

I think it would be interesting to keep the directory structure that is common with all the xeus-based kernels for the documentation. For example, this broke the link to the logo in the readme.

@vgvassilev
Copy link
Contributor

@Krishna-13-cyber, could you look into this?

@SylvainCorlay, do we have a better place to that documentation?

@SylvainCorlay
Copy link
Collaborator

I think it is all fine! My comment was merely that moving the source files from docs/source to docs makes this repo slightly different from others - and accedentaly broke the readme.

This also makes re-generating the cookie-cutter bits harder.

@Krishna-13-cyber
Copy link
Contributor Author

Krishna-13-cyber commented Nov 16, 2023

I think it is all fine! My comment was merely that moving the source files from docs/source to docs makes this repo slightly different from others - and accedentaly broke the readme.

This also makes re-generating the cookie-cutter bits harder.

Hi,
So, should we make it back to the original convention of docs/source?

@SylvainCorlay
Copy link
Collaborator

So, should we make it back to the original convention of docs/source?

That would be great - just for keeping the xeus-based kernel as similar as possible where possible.

@Krishna-13-cyber
Copy link
Contributor Author

So, should we make it back to the original convention of docs/source?

That would be great - just for keeping the xeus-based kernel as similar as possible where possible.

Yes, I will get this done.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants