feat: xcpp support reexecution #80
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Patch submitted to LLVM under llvm/llvm-project#75547 |
|
This seems to work perfectly. Can anyone verify it? |
|
I have tried to build this repo today without success. There are new build instructions in the main branch and neither work for me. |
|
At least post an error message and build logs. Anyways, this patch breaks the See issue #72, I've gathered all the information there. |
|
xeus-clang-repl is being ported to xeus-cpp. Please take a look there, although there is no re-execution support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly support reexecution by putting cell code inside nested namespaces __xns1::__xns2::...
Fixes: #72