Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear sim config change - allow init_data in test_linear_simulator.py to accept yaml files #133

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

qingyuan-wu
Copy link

Address issue 118

Checklist

Verify that your PR checks all the following items.

  • The pull request (PR) has a clear and explanatory title.
  • The description of this PR links to relevant GitHub issues.
  • Unit tests have been added in the tests folder:
    • in the test_*.py files corresponding the files modified by this PR,
    • for each function added by this PR.
  • The code of this PR is properly documented, with docstrings following simSPI conventions.
  • The PR passes the DeepSource GitHub Actions workflow (refer to comment below).
  • The PR passes Test and Lint GitHub Actions workflows. (refer to comment below)

If some items are not checked, mark your PR as draft (Look for "Still in progress? Convert to Draft" on your PR) . Only mark the PR as "Ready for review" if all the items above are checked.

If you do not know how to address some items, reach out to a maintainer by requesting reviewers.

If some items cannot be addressed, explain the reason in the Description of your PR, and mark the PR ready for review

Description

Issue

Additional context

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant