Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop connections that didn't recently reply to a PING. #196

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[submodule "src/backend"]
path = src/backend
url = https://github.com/communi/libcommuni.git
url = https://github.com/mornfall/libcommuni
[submodule "src/shared"]
path = src/shared
url = https://github.com/communi/communi-shared.git
url = https://github.com/communi/communi-shared.git
6 changes: 6 additions & 0 deletions src/app/bufferproxymodel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
#include <IrcBufferModel>
#include <IrcConnection>
#include <IrcBuffer>
#include <IrcLagTimer>

IRC_USE_NAMESPACE

Expand Down Expand Up @@ -147,13 +148,18 @@ void BufferProxyModel::addConnection(IrcConnection* connection)

void BufferProxyModel::insertConnection(int index, IrcConnection* connection)
{
connection->network()->setRequestedCapabilities(Irc::supportedCapabilities());

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check why this wasn't done before.

IrcBufferModel* model = new IrcBufferModel(connection);
model->setSortMethod(static_cast<Irc::SortMethod>(m_method));
connect(model, &IrcBufferModel::added, this, &BufferProxyModel::bufferAdded);
connect(model, &IrcBufferModel::removed, this, &BufferProxyModel::bufferRemoved);
connect(model, &IrcBufferModel::aboutToBeAdded, this, &BufferProxyModel::bufferAboutToBeAdded);
connect(model, &IrcBufferModel::aboutToBeRemoved, this, &BufferProxyModel::bufferAboutToBeRemoved);

IrcLagTimer* lag = new IrcLagTimer(model);
lag->setConnection(connection, true);

ZncManager* znc = new ZncManager(model);
znc->setModel(model);

Expand Down