Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix unit tests for #5262 ("Remove location" button for new uploads) #5337

Closed
wants to merge 20 commits into from
Closed

Feature/fix unit tests for #5262 ("Remove location" button for new uploads) #5337

wants to merge 20 commits into from

Conversation

TomerPacific
Copy link

Description (required)
#5262 introduces a useful feature, but makes two unit tests fail.
The two units tests that are failing are:

  • testOnClickModifyLocation
  • testOnStyleLoaded

Fixes #5291

What changes did you make and why?

Added a variable to mock the newly added removeLocationButton

Tests performed (required)

Tested unit tests on an emulated device with API level 29

Screenshots (for UI changes only)
N/A

paco-arana and others added 20 commits July 23, 2023 18:17
…nt. Linked to empty onClickRemoveLocation method.
…. Linked to empty removeLocationFromPicture() method.
@nicolas-raoul
Copy link
Member

Thanks a lot for fixing the unit tests!

I just performed more real-world tests, and realized latitude/longitude are not actually removed from the EXIF of the picture. Hopefully this will be fixed soon and I will be able to merge. :-)

@TomerPacific
Copy link
Author

TomerPacific commented Oct 14, 2023

@nicolas-raoul - Do you mind adding the hacktoberfet-accepted label?
Also, would you like me to help out with the rest of this feature?

@nicolas-raoul
Copy link
Member

@TomerPacific

I added the label.
Sure, that would be wonderful! Feel free to create another branch, and pull from this branch into it.

@TomerPacific
Copy link
Author

@nicolas-raoul - Can you elaborate on what the statement you made means:

I just performed more real-world tests, and realized latitude/longitude are not actually removed from the EXIF of the picture.

What exactly did you try and what exactly did you see (and how)?

Thanks

@nicolas-raoul
Copy link
Member

Sure!
I just added reproduction steps at #5262 (comment)

@nicolas-raoul
Copy link
Member

Please do not hesitate to comment at #5262 (comment) 🙂

@nicolas-raoul nicolas-raoul changed the title Feature/fix unit tests Feature/fix unit tests for #5262 ("Remove location" button for new uploads) Oct 20, 2023
@TomerPacific TomerPacific closed this by deleting the head repository Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unit tests for pull request #5262
3 participants