Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use standard geo: URI format #5268

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

mnalis
Copy link
Contributor

@mnalis mnalis commented Aug 9, 2023

(like OsmAnd, StreetComplete etc do), which works with all apps, and not only some.

Description (required)
Clicking on coordinates in app sends the intent to open user-defined geo-enabled app. However, the specific intent format used only works for some apps, but fails on many others (it opens 0,0 coordinates instead).

This PR implements strict RFC 5870 geo: format, which should be supported by all apps.

Fixes #5264

Tests performed (required)

Tested ProdDebug on Huawei P30 Pro with API level {API level}.

Screenshots (for UI changes only)


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

(like OsmAnd, StreetComplete etc do), which works with all apps, and not only some.
@mnalis
Copy link
Contributor Author

mnalis commented Aug 10, 2023

Tested and now works correctly in all apps:

small_SVID_20230810_105235_1.mp4

@mnalis mnalis marked this pull request as ready for review August 10, 2023 08:55
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! :-)

@nicolas-raoul nicolas-raoul merged commit d2cd6df into commons-app:master Aug 10, 2023
1 check passed
@mnalis mnalis deleted the fix-geo-intent branch August 11, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: trying to share geograpic location only works in SOME apps
2 participants