-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Remove location" button for new uploads #5262
Closed
Closed
Changes from 8 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e0d0e77
Added styling for "remove location" button to be shown when opening l…
paco-arana a1be991
Added english language strings for remove location button and popup
paco-arana 210bf23
Merge branch 'commons-app:master' into removelocation
paco-arana 7160d6a
Added code to display remove button whenever the edit button is prese…
paco-arana d96be6b
Merge remote-tracking branch 'origin/removelocation' into removelocation
paco-arana 01f3654
Added popup to be displayed when clicking on "remove location" button…
paco-arana 34b3013
Added contents of removeLocationFromPicture() method
paco-arana 818fc74
Modified removeLocationFromPicture() to save and exit
paco-arana df90bde
Methods now set coords to null instead of 0,0.
paco-arana 8e596c6
Merge branch 'commons-app:master' into removelocation
paco-arana ec0d9b6
Simplified removeLocationFromPicture()
paco-arana efa657b
Attempt 1: Added removeLocationButton to tests
paco-arana 968cb49
Attempt 2: Moved loc removal to placeSelected()
paco-arana 8b92253
Attempt 3: Testing without method.invoke()
paco-arana 230a1d4
Attempt 4: Placing camera loc to 0,0 and using boolean to remove it e…
paco-arana 5f9feb9
Rolling back changes to tests
paco-arana 1e8049d
Rolling back changes to activity
paco-arana 0f959c3
Attempt 5: Simplified method. Made Style Nullable
paco-arana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far! As you wrote, removing location altogether is needed here. 🙂