Fixes 3463 replace assert with assert that #5107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u7281898
changed the title
u7281898
changed the title
nicolas-raoul
requested changes
Oct 31, 2022
| @@ -47,6 +47,7 @@ dependencies { | |||
| implementation 'com.karumi:dexter:5.0.0' | |||
| implementation "com.jakewharton:butterknife:$BUTTERKNIFE_VERSION" | |||
| implementation 'androidx.lifecycle:lifecycle-extensions:2.2.0' | |||
| // implementation 'com.google.firebase:firebase-firestore:24.1.2' | |||
| //import static org.junit.Assert.assertThat; | ||
| //import static org.hamcrest.Matchers.is; | ||
| //import static org.hamcrest.Matchers.not; | ||
| //import static org.hamcrest.Matchers.nullValue; |
| @@ -991,6 +995,7 @@ public void onActivityResult(final int requestCode, final int resultCode, | |||
|
|
|||
| if (requestCode == REQUEST_CODE && resultCode == RESULT_OK) { | |||
|
|
|||
| // assertThat(data, not(nullValue())); | |||
|
|
||
| defaultConfig { | ||
| minSdkVersion 19 | ||
| targetSdkVersion 28 | ||
| targetSdkVersion 30 |
| @@ -3,13 +3,16 @@ package fr.free.nrw.commons.auth | |||
| import fr.free.nrw.commons.FakeContextWrapper | |||
| import fr.free.nrw.commons.FakeContextWrapperWithException | |||
| import fr.free.nrw.commons.TestCommonsApplication | |||
| import org.junit.Assert | |||
| import org.junit.Assert.* | |||
There was a problem hiding this comment.
Would you mind importing only the needed classes, explicitly?
| import org.junit.Before | ||
| import org.junit.Test | ||
| import org.junit.runner.RunWith | ||
| import org.robolectric.RobolectricTestRunner | ||
| import org.robolectric.RuntimeEnvironment | ||
| import org.robolectric.annotation.Config | ||
| import org.hamcrest.CoreMatchers.*; |
There was a problem hiding this comment.
Would you mind importing only the needed classes, explicitly?
|
Closing this as now stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #3463
What changes did you make and why?
I replaced all instances of assert() with assertThat() where appropriate.
assertThat() error messages are easier to understand and the assertThat method has a wider range of abilities to determine if the output of a function is appropriate. For example assertThat will not complete compiling instead of failing if the expected input is an integer instead of a string.
Tests performed (required)
Tested AccountUtilUnitTest with Pixel 2 API 30