Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Debt] Remove usage of deprecated startActivityForResult & onActivityResult APIs in favour of decoupled result APIs #5849

Open
parneet-guraya opened this issue Oct 14, 2024 · 2 comments · May be fixed by #5875
Open

[Tech Debt] Remove usage of deprecated startActivityForResult & onActivityResult APIs in favour of decoupled result APIs #5849

parneet-guraya opened this issue Oct 14, 2024 · 2 comments · May be fixed by #5875
Assignees
@parneet-guraya
Labels
code-quality enhancement

Comments

@parneet-guraya
Copy link
Contributor

Remove usage of deprecated startActivityForResult & onActivityResult APIs in favour of decoupled result APIs.

While the underlying startActivityForResult() and onActivityResult() APIs are available on the Activity class on all API levels, Google strongly recommends using the Activity Result APIs introduced in AndroidX Activity and Fragment classes.

For more on what benefits it offers refer here https://developer.android.com/training/basics/intents/result#custom

P.S: We already have newer code using this API. Only some place that needs refactor.
@parneet-guraya
Copy link
Contributor Author

I have done this migrations a few times. So, I'd like to work on this :)

@parneet-guraya parneet-guraya mentioned this issue Oct 14, 2024
Closed
@parneet-guraya
Copy link
Contributor Author

Waiting for this one #5851 to merge and then I will continue.

@parneet-guraya parneet-guraya linked a pull request Oct 19, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parneet-guraya parneet-guraya

Labels
code-quality enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new result API parneet-guraya/apps-android-commons
2 participants
@nicolas-raoul @parneet-guraya