Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary request code checks while handling file picker results #5850

Closed
parneet-guraya opened this issue Oct 14, 2024 · 0 comments · Fixed by #5851
Closed

Remove unnecessary request code checks while handling file picker results #5850

parneet-guraya opened this issue Oct 14, 2024 · 0 comments · Fixed by #5851

Comments

@parneet-guraya
Copy link
Contributor

While working on #5849, I saw, there are some problems with handling request codes in FilePicker.java

I chose not to include these changes in the refactor (refer #5849) because these are distinct changes which should be addressed separately and it'd easier to understand from git history.

Problems were ->

  • Capture Video flag was still being checked even though we never use it in any intent to launch anything.

  • Even when using Document PIcker (default) , the Intent created for launching it, is passed with Gallery Picker/Photo Picker requestCode which means for both of the methods result will be handled by only Gallery picker's callback. Though I'm not sure if this lead to any bug but still we should be using respective callbacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant