Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Added preview links for new-docs #32900

Closed
wants to merge 1 commit into from

Conversation

ugtthis
Copy link
Contributor

@ugtthis ugtthis commented Jul 3, 2024

  • Doc site is built and deployed on Cloudflare Pages similar to new-connect
  • Comments a preview link whenever a PR happens
  • CLOUDFLARE_PAGES_TOKEN and CLOUDFLARE_ACCOUNT_ID are required.
  • Instead of separating build and preview, I put them together into new-docs.yaml
  • As seen below, is an example out. I tested out this here to see how it looks.
  • Link to PR Preview: https://pr-15.docs-openpilot.pages.dev/
  • First step towards new docs.comma.ai #32812

pr-link-example

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@ugtthis ugtthis closed this Jul 3, 2024
@ugtthis ugtthis deleted the add-docs-preview-link branch August 5, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant