Only query single route if segmentRange specified #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to connect! Make sure to:
deployed preview: https://544.connect-d5y.pages.dev |
sshane
commented
Jul 12, 2024
| @@ -148,7 +166,12 @@ export function urlForState(dongleId, log_id, start, end, prime) { | |||
| } | |||
|
|
|||
| function updateTimeline(state, dispatch, log_id, start, end, allowPathChange) { | |||
| dispatch(checkRoutesData()); | |||
There was a problem hiding this comment.
Added in #419, I'm not sure why. It re-queries the API twice on loading any route (from URL only). With this change, this ends up breaking something in ACTION_ROUTES_METADATA as it is also called twice; the second time segmentRange's start and end values are properly set, but that function only works if they're both NaN on first load (??). On master, querying the API the first time here is fine because the limit param just happens to be set to 0 so currentRoute isn't set yet, which would change segmentRange's start and end lol
In summary: I'm amazed connect works as well as it does
sshane
changed the title
sshane
changed the title
|
Implemented these changes in: #522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes two queries on loading a route on master and the other attempt at this