Fixing loop setting. #535
Merged
Fixing loop setting. #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to connect! Make sure to:
deployed preview: https://535.connect-d5y.pages.dev |
sshane
reviewed
Jul 16, 2024
src/reducers/globalState.js
Outdated
Comment on lines
309
to
313
|
|
||
| state.loop = { | ||
| startTime: state.zoom.start, | ||
| duration: state.zoom.end - state.zoom.start, | ||
| }; |
There was a problem hiding this comment.
I believe this is only masking over the problem, in that popTimelineRange isn't used the same way when using the browser back buttons, but adding an event listener seems to make the behavior even more buggy
|
this is also a reminder that we should not have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #534