CI: reduce puppeteer test time from 34s to 13s #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace all `await sleep(...)`s with correct Page.waitForSelector and other query selectors Before: ``` PASS src/__puppeteer__/offline.test.js (8.013 s) PASS src/__puppeteer__/routing.test.js (22.464 s) PASS src/__puppeteer__/demo.test.js (33.238 s) ``` After: ``` PASS src/__puppeteer__/offline.test.js (7.93 s) PASS src/__puppeteer__/demo.test.js (8.148 s) PASS src/__puppeteer__/routing.test.js (12.262 s) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all
await sleep(...)s with correct Page.waitForSelector and other query selectors.Before:
After:
Tests should also be less flaky now as the sleeps are not hard-coded for each test.
This is much faster to run locally, but GitHub actions still appears to be pretty slow :/