-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show snackbar on update ready #316
Conversation
Can we just reload instead? |
I guess if we are OK with losing whatever state the app has at that time, then yeah, although I guess there isn't much state that isn't in the URL right now. I'm also going to look into this a bit more because apparently it can cause bugs if for example multiple tabs are open and you switch service worker. |
cf07e72
to
5566048
Compare
In Create React App, the default service worker installs updates immediately when available and discards the old cache, causing the "chunk failed to load" errors when the user tries to load other routes (#312) since they are still browsing on the old site with old JS/HTML referencing now non-existent resources. We can fix this by adding our own |
2c065cb
to
0e7c174
Compare
f8f12df
to
581de73
Compare
Related: