-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: #3550 ; Add hello-world Android Java Example using Mill #3659
base: main
Are you sure you want to change the base?
Fixes: #3550 ; Add hello-world Android Java Example using Mill #3659
Conversation
@lihaoyi Sir please don't get irritated by my doubts(i am newbie) please clear my last doubt... basically when i reviewed
so after this i came to know that even
and when i tried this same thing then i got shocked this time it got the files and sources, see:
Final Verdict: we also need to use please share your thoughts and suggestions... |
Yes the filesystem hierarchy has to match the module hierarchy |
Thanks Alot Sir finally now i got answers to all of my doubts... |
@lihaoyi Thankyou Sir for the detailed feedback! I’ve addressed all the requested changes and resolved the comments. Please let me know if anything else needs attention. Please pardon me if I missed anything or made a mistake. Looking forward to your final review and any further suggestions! |
Description
This PR fixes #3550 by adding a "hello-world" Android Java example using Mill.
Changes:
1-hello-world
folder insideexample/javalib/android
src
folder for sources and abuild.mill
file.AndroidSdkModule.scala
: This module handles the SDK setup.AndroidAppModule.scala
: This module extends bothAndroidSdkModule
andJavaModule
to ensure proper functionality.build.mill
, extended theApp
module for building the Android application.android_examples.adoc
created and referred in navbar.adoc, finally tested.example/{javalib,kotlinlib,scalalib}
andscalalib/{Modules...}
.scaladoc{AndroidAppModule, AndroidScalaModule}
)Type of Change
Related Issues
issue #3550
Testing
Tested by building the Android app using Mill, ensuring that both the
AndroidSdkModule
andAndroidAppModule
work together as expected. Successfully generated the APK and verified the "Hello World" functionality.Checklist
Additional Notes
Feel free to review the code and let me know if any further improvements are needed.
Screenshots