Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove : from all migration file names 🗂️ #97

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

ramiAbdou
Copy link
Member

@ramiAbdou ramiAbdou commented Apr 4, 2024

Description ✏️

Closes #96.

This PR does the following:

  • Renames migration files, specifically removes colons from the files.
  • Adds documentation on how to common migration errors.
  • Adds link to that documentation in the error log of a failed migration.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Apr 4, 2024
@ramiAbdou ramiAbdou marked this pull request as ready for review April 4, 2024 22:48
@ramiAbdou ramiAbdou merged commit b238398 into main Apr 4, 2024
1 check passed
@ramiAbdou ramiAbdou deleted the rami/migrations branch April 4, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows cannot create migration files with : character 🪟
1 participant