-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement allow_email_share
field 📬
#57
feat: implement allow_email_share
field 📬
#57
Conversation
...ages/core/src/infrastructure/database/migrations/2024-03-31T15:39:09Z-share-email-default.ts
Outdated
Show resolved
Hide resolved
...ages/core/src/infrastructure/database/migrations/2024-03-31T15:39:09Z-share-email-default.ts
Outdated
Show resolved
Hide resolved
packages/core/src/infrastructure/database/migrations/2024-03-31T15:36:45Z-share-email.ts
Outdated
Show resolved
Hide resolved
packages/core/src/infrastructure/database/migrations/2024-03-31T21:37:51Z-share-email.ts
Outdated
Show resolved
Hide resolved
packages/core/src/infrastructure/database/migrations/2024-03-31T21:37:51Z-share-email.ts
Show resolved
Hide resolved
ca68018
to
42648d2
Compare
42648d2
to
7bf063a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent work, @tomas-salgado! I can't believe you ramped up so quickly with this. 😅 Just have a few small suggestions, and we should be good to go!
packages/core/src/infrastructure/database/migrations/2024-03-31T21:37:51Z-share-email.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested this locally and it works beautifully! 🙌
I pushed a small fix which adds the id
to the checkbox which makes the label of the checkbox clickable - if you can just merge those changes in, we should be good to ship!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
allow_email_share
field 📬
Description ✏️
Implement a checkbox on the emails page that allows members to opt-in or opt-out of having their email shared with Chapter Leaders.
Closes #51
allow_email_share
field tostudents
table in dballow_email_share
a value ofTrue
allow_email_share
value in database for that userAfter:
![Screenshot 2024-04-02 at 12 22 26 PM](https://private-user-images.githubusercontent.com/91388965/318873102-9937a6cb-4b42-41e6-88f6-c9fe23f62559.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mjk2MjQ3NzcsIm5iZiI6MTcyOTYyNDQ3NywicGF0aCI6Ii85MTM4ODk2NS8zMTg4NzMxMDItOTkzN2E2Y2ItNGI0Mi00MWU2LTg4ZjYtYzlmZTIzZjYyNTU5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEwMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMDIyVDE5MTQzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUzYzY0ZWE0NjJmMTBmYWViZjY3MDgxNDcyNzAzMWRhMzQ5MGY0ZWFhM2JkNWI1NTI3ZGMwZmRlYmU2YWZlMzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.vBGrCBaydu1_Dz5fHfYrsYh_qHzl1giPLQPvZctL1JM)
Before:
![Screenshot 2024-04-01 at 10 36 04 PM](https://private-user-images.githubusercontent.com/91388965/318621720-08f65278-9724-4cca-9156-e463bc741aec.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mjk2MjQ3NzcsIm5iZiI6MTcyOTYyNDQ3NywicGF0aCI6Ii85MTM4ODk2NS8zMTg2MjE3MjAtMDhmNjUyNzgtOTcyNC00Y2NhLTkxNTYtZTQ2M2JjNzQxYWVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEwMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMDIyVDE5MTQzN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYwNTU2M2RhNmVlMjdlYjgxNTY5ODMyOWRiNmUzNTg3OTNlYzY2YjFkNjMwMGMxZTVlYjU1NzJkNDdmNjAzMjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dyyUwy-efg4BQTwCns93QUdp6smVQt0KrYEWTT-CNRo)
Type of Change 🐞
Checklist ✅