Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement allow_email_share field 📬 #57

Merged
merged 25 commits into from
Apr 2, 2024

Conversation

tomas-salgado
Copy link
Collaborator

@tomas-salgado tomas-salgado commented Mar 31, 2024

Description ✏️

Implement a checkbox on the emails page that allows members to opt-in or opt-out of having their email shared with Chapter Leaders.

Closes #51

  • adds allow_email_share field to students table in db
  • default gives allow_email_share a value of True
  • implements db migrations
  • implement frontend checkbox on emails page, where initial value (checked or not) is in line with allow_email_share value in database for that user
  • implement backend functionality such that database is updated when checkbox is clicked

After:
Screenshot 2024-04-02 at 12 22 26 PM

Before:
Screenshot 2024-04-01 at 10 36 04 PM

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@tomas-salgado tomas-salgado changed the title feat: implement share email field feat: implement share email field 📬 Mar 31, 2024
@tomas-salgado tomas-salgado changed the title feat: implement share email field 📬 feat: implement allow_email_share field 📬 Mar 31, 2024
@tomas-salgado tomas-salgado marked this pull request as ready for review April 2, 2024 03:18
Copy link
Member

@ramiAbdou ramiAbdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent work, @tomas-salgado! I can't believe you ramped up so quickly with this. 😅 Just have a few small suggestions, and we should be good to go!

Copy link
Member

@ramiAbdou ramiAbdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this locally and it works beautifully! 🙌

I pushed a small fix which adds the id to the checkbox which makes the label of the checkbox clickable - if you can just merge those changes in, we should be good to ship!

Copy link
Member

@ramiAbdou ramiAbdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ramiAbdou ramiAbdou changed the title feat: implement allow_email_share field 📬 feat: implement allow_email_share field 📬 Apr 2, 2024
@ramiAbdou ramiAbdou merged commit 4f8042e into colorstackorg:main Apr 2, 2024
1 check passed
@tomas-salgado tomas-salgado deleted the share-email-field branch April 2, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share member contact info with Chapter Leaders 📬
3 participants