Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: grammar for "ethnicity(s)" 🤓 #562

Merged
merged 4 commits into from
Oct 21, 2024
Merged

fix: grammar for "ethnicity(s)" 🤓 #562

merged 4 commits into from
Oct 21, 2024

Conversation

im6rn
Copy link
Contributor

@im6rn im6rn commented Oct 15, 2024 •
edited
Loading

Description ✏️

fixes member directory signup flow to say "ethnicity/ies" instead of "ethnicity(s)" + added name to CONTRIBUTORS.yml lol

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@im6rn im6rn requested a review from ramiAbdou as a code owner October 15, 2024 03:11
@tomas-salgado
adding line at end of file
87dd69d 
the file needs a blank line at the end of the file :)
tomas-salgado
tomas-salgado approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tomas-salgado tomas-salgado added the Ready for Rami ✅ This PR is ready for a final review label Oct 17, 2024
@ramiAbdou ramiAbdou merged commit 3d04dcb into colorstackorg:main Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramiAbdou ramiAbdou ramiAbdou approved these changes

@tomas-salgado tomas-salgado tomas-salgado approved these changes

Assignees

@im6rn im6rn

Labels
Ready for Rami ✅ This PR is ready for a final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@im6rn @ramiAbdou @tomas-salgado