Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use developer email for sending emails in development 📫 #56

Merged
merged 16 commits into from
Mar 31, 2024

Conversation

ramiAbdou
Copy link
Member

@ramiAbdou ramiAbdou commented Mar 31, 2024

Description ✏️

Closes #46.

This PR allows developers to use their own email address for sending emails in development.

  • Requires the following environment variables in development in order to send emails: SMTP_HOST, SMTP_PASSWORD, SMTP_USERNAME.
  • Uses nodemailer to send emails.
  • Refactors the sendEmail function.
  • Adds documentation for enabling email sending in development.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Mar 31, 2024
@ramiAbdou ramiAbdou merged commit 7ecadc3 into main Mar 31, 2024
1 check passed
@ramiAbdou ramiAbdou deleted the rami/nodemailer branch March 31, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postmark not sending emails for new accounts b/c mismatched from ✉️
1 participant