Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 'Companies' page layout 💼 #544

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Wisesofthemall
Copy link
Contributor

Description ✏️

Closes #536

Describe what this PR does.
Untitled Video October 1, 2024 1_33 AM

  • Bullet points are helpful.
  • Screenshots are helpful, if applicable.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wisesofthemall I'm curious to hear reasoning for why we should have each of the parts of this page (employees, reviews, etc.) into separate pages? My initial thought was that since there isn't really too much data it's fine to implement this issue by just making a change in a single file where we just only render whatever section is selected (so even if all the data is loaded, we only show a section of it at a time for ease of use). Just curious to hear if you considered this, and which approach you think might be better here!

@tomas-salgado tomas-salgado changed the title New Companies page layout feat: 'Companies' page layout 💼 Oct 17, 2024
@Wisesofthemall
Copy link
Contributor Author

@Wisesofthemall I'm curious to hear reasoning for why we should have each of the parts of this page (employees, reviews, etc.) into separate pages? My initial thought was that since there isn't really too much data it's fine to implement this issue by just making a change in a single file where we just only render whatever section is selected (so even if all the data is loaded, we only show a section of it at a time for ease of use). Just curious to hear if you considered this, and which approach you think might be better here!

Given the example listed (Recap page), that page uses separate pages to render specific pieces of data, so I was just following that logic. Additionally, with the use of separate pages, I'm utilizing Server-Side Rendering (SSR) as opposed to Client-Side Rendering (CSR), and here are the benefits:

Improved Performance: SSR can reduce the initial load time, especially for users on slower networks, as the content is pre-rendered on the server.

SEO Benefits: Pages rendered on the server are better optimized for search engines, which can improve the visibility of the content.

Scalability: As data grows, separating sections into different pages can help keep each page lightweight and maintain performance.

@Wisesofthemall
Copy link
Contributor Author

But of course, I can refactor to Client Side Routing if its necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Companies page layout 📑
2 participants