Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hover tooltip to show rejection reason for referrals 👤❌💬 #542

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: hover tooltip to show rejection reason for referrals 👤❌💬 #542

wants to merge 8 commits into from
+63 −3

Conversation

wflore19
Copy link
Contributor

@wflore19 wflore19 commented Sep 30, 2024 •
edited
Loading

Description ✏️

Closes #532

  • Allows users to view the specific reasons why certain referrals were rejected

rejection_reason_feature

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@wflore19
Copy link
Contributor Author

wflore19 commented Oct 7, 2024

I'm going to double check and work on this with my Bloomberg mentor 📝

tomas-salgado
tomas-salgado approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @wflore19! I also tested this locally and it's working perfectly. Left one minor comment regarding wording but otherwise this LGTM!

apps/member-profile/app/shared/utils/format.utils.ts Outdated Show resolved Hide resolved
@tomas-salgado tomas-salgado added the Ready for Rami ✅ This PR is ready for a final review label Oct 17, 2024
@wflore19
Copy link
Contributor Author

Great work @wflore19! I also tested this locally and it's working perfectly. Left one minor comment regarding wording but otherwise this LGTM!

DancingHypeGIF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-salgado tomas-salgado tomas-salgado approved these changes

@ramiAbdou ramiAbdou Awaiting requested review from ramiAbdou ramiAbdou is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

@wflore19 wflore19

Labels
Ready for Rami ✅ This PR is ready for a final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rejection Reason Tooltip ❌
2 participants
@wflore19 @tomas-salgado