feat: Leetcode Company Tagged 🗂️ #530
Open
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-salgado
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Great work @cjohnson74! Just left some comments regarding changing some naming, but otherwise the code and the functionality looks great to me!
| @@ -154,6 +155,10 @@ export default function CompanyPage() { | |||
| {company.levelsFyiSlug && ( | |||
| <LevelsFyiLink slug={company.levelsFyiSlug} /> | |||
| )} | |||
|
|
|||
| {company.leetcodeTagged && ( | |||
| <LeetcodeTaggedLink leetcode_tagged={company.leetcodeTagged} /> | |||
There was a problem hiding this comment.
let's change the naming from leetcode_tagged to slug, so we can have consistency with the pattern used for the Levels.fyi link as well
| export async function up(db: Kysely<any>) { | ||
| await db.schema | ||
| .alterTable('companies') | ||
| .addColumn('leetcode_tagged', 'varchar') |
There was a problem hiding this comment.
let's change leetcode_tagged to leetcode_tagged_slug to follow the pattern that's used with levels_fyi_slug
fetching updates
…eetcode-tagged pulling changes
tomas-salgado
requested changes
Oct 7, 2024
| @@ -46,6 +46,7 @@ export async function loader({ params, request }: LoaderFunctionArgs) { | |||
| 'companies.imageUrl', | |||
| 'companies.name', | |||
| 'companies.levelsFyiSlug', | |||
| 'companies.leetcodeTagged', | |||
There was a problem hiding this comment.
Since we're changing the name to leetcodeTaggedSlug in the database, we need to have that changed reflected here
Comment on lines
159
to
160
| {company.leetcodeTagged && ( | ||
| <LeetcodeTaggedLink slug={company.leetcodeTagged} /> |
There was a problem hiding this comment.
we also need to change the name in these two lines
…eetcode-tagged Pulling to push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description ✏️
Closes #516
Type of Change 🐞
Checklist ✅