Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make one time code email synchronous ✉️ #52

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Conversation

ramiAbdou
Copy link
Member

@ramiAbdou ramiAbdou commented Mar 31, 2024

Description ✏️

Closes #47.

This PR does the following:

  • Converts email sending to synchronous in sendOneTimeCode, instead of a Bull job.
  • Requires the POSTMARK_API_TOKEN environment variable in both FE applications.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Mar 31, 2024
@ramiAbdou ramiAbdou merged commit 4a3c9da into main Mar 31, 2024
1 check passed
@ramiAbdou ramiAbdou deleted the rami/sync branch March 31, 2024 01:26
omar-elbaz pushed a commit to omar-elbaz/oyster that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTP notification fails silently, but should display message ❌
1 participant