Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: buggy indexing of array for reranking 🐞 #515

Merged
merged 1 commit into from
Sep 14, 2024
Merged

fix: buggy indexing of array for reranking 🐞 #515

merged 1 commit into from
Sep 14, 2024

Conversation

ramiAbdou
Copy link
Member

Description ✏️

This PR fixes a bug that wrongly indexes the reranked documents that get returned from the Cohere API.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou marked this pull request as ready for review September 14, 2024 00:43
@ramiAbdou ramiAbdou merged commit 63c757b into main Sep 14, 2024
2 checks passed
@ramiAbdou ramiAbdou deleted the rami/fix branch September 14, 2024 00:45
iperalta7 pushed a commit to iperalta7/oyster that referenced this pull request Sep 25, 2024
@ramiAbdou @iperalta7
fix: buggy indexing of array for reranking 🐞 (colorstackorg#515)
4d6d032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ramiAbdou ramiAbdou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ramiAbdou