Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: infrastructure for school chapters 📖 #500

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

iperalta7
Copy link
Contributor

@iperalta7 iperalta7 commented Sep 4, 2024

Description ✏️

Closes #498
A chapters table is created, so that admins can mark a school that has a chapter.

  • Should store schools that have chapters by linking school_id and storing timestamp when school was added to chapters table

  • New dropdown with a confirmation modal to add a school to chapters table (should not be shown for schools already in table)

  • Add new dropdown field to school to add as a chapter in admin dashboard

    • only show if not a chapter yet
    • confirmation modal
  • New data table for chapters

    • Columns: school_id, added_time_stamp
chapter-infra-pr.-.Made.with.Clipchamp.mp4

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@iperalta7 iperalta7 changed the title dev: test feat: Add infrastructure for school chapters Sep 4, 2024
@iperalta7 iperalta7 changed the title feat: Add infrastructure for school chapters feat: infrastructure for school chapters Sep 4, 2024
@iperalta7 iperalta7 force-pushed the infra-school-chapters branch 3 times, most recently from 846a910 to 15a613a Compare September 5, 2024 01:39
@iperalta7 iperalta7 marked this pull request as ready for review September 5, 2024 01:39
@iperalta7
Copy link
Contributor Author

Tried to leave this more open for extension, since this is only a small start for chapters. Therefore, I mimicked more of how the school creation works with some core files in @oyster/core. I'd appreciate if this was the right track to go?

Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and it's working great! Left a few minor comments-almost ready to go

@iperalta7 iperalta7 force-pushed the infra-school-chapters branch 3 times, most recently from bc9e08d to 795dfeb Compare September 25, 2024 17:09
@iperalta7
Copy link
Contributor Author

iperalta7 commented Sep 25, 2024

@tomas-salgado should be all set now :) Thanks for the review! Ended up giving it a rebase to fixup my commit with your comments

Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @iperalta7! LGTM 🚀

@tomas-salgado tomas-salgado added the Ready for Rami ✅ This PR is ready for a final review label Oct 7, 2024
@tomas-salgado tomas-salgado changed the title feat: infrastructure for school chapters feat: infrastructure for school chapters 📖 Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for Rami ✅ This PR is ready for a final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infrastructure for School Chapters 🧱
2 participants