-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ability to add phone number in profile 📲 #482
feat: ability to add phone number in profile 📲 #482
Conversation
9bbdc0a
to
14c400a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff @Hamza-Mos! Just left a few minor comments but almost good to go!
e6ee230
to
60f6a5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @Hamza-Mos, LGTM!
…e-numbers-to-member-profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, @Hamza-Mos! 💯
Phone number formatting can get very difficult and I thought you killed that formatPhoneNumber
function! That was a neat trick you used to keep the end parenthesis open when the digit length was 3, which made it easy to delete the 4th number (and similarly for the -
).
I made an update so that we're only storing digits in our database as opposed to the parentheses/dashes! Thought about storing the country code as well, but don't think we need to since we're only serving US/Canada-based folks. Luckily we avoided a whole slew of complexity by not serving international numbers cause then we would've had to use something like react-phone-number-input which is really heavy and nasty haha.
Can't wait to see this in prod!
Description ✏️
Closes #471
Screenshots:
Empty:
Invalid:
Valid:
Database:
Type of Change 🐞
Checklist ✅