-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support anonymous company reviews 👻 #437
feat: support anonymous company reviews 👻 #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @jasonappah! This PR is almost there, just a few things to add.
I tried testing the feature locally, but it seems that the anonymous
field is not getting updated in the database when I create a new review. I suspect the issue here is that we need to pass in anonymous
in add-company-review.ts, and similarly in edit-company-review.ts. Then we just need to ensure that we're loading this value from the database properly.
Let me know if you need any help on this or have any questions/comments!
packages/db/src/migrations/20240808004625_anon_company_reviews.ts
Outdated
Show resolved
Hide resolved
Tested again locally and everything seems to be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @jasonappah! Thank you so much for the work here!
I'm expecting some 2/10 reviews to be posted anonymously soon! 😂😂
531efce
to
6058cf8
Compare
Description ✏️
Closes #302.
This PR adds support for anonymous company reviews, where members can create company reviews without their names being displayed.
Type of Change 🐞
Checklist ✅