Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset search after creating resource tag 🏷️ #436

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

iperalta7
Copy link
Contributor

@iperalta7 iperalta7 commented Aug 7, 2024

Description ✏️

Closes #272

Describe what this PR does.

  • Modifies reset() to call and reset the tag list with listFetcher.submit() to ensure the list of available tags shows when a new tag is created.
  • See issue to see the bug, the following video shows how it changed:
pr1.mp4

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@iperalta7 iperalta7 marked this pull request as ready for review August 8, 2024 01:31
@iperalta7
Copy link
Contributor Author

Will add a quick video later today to showcase this, but can easily be seen in local environment

Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🛫

Copy link
Member

@ramiAbdou ramiAbdou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here @iperalta7! 🚀

I made a slight tweak which updated the functionality for all MultiCombobox's that are used throughout our applications, b/c this was actually a bit more of an underlying issue with that component than just the ResourceTagsField (though your solution fixed that piece perfectly). The crux of the issue is that the onChange handler wasn't getting trigger in the MultiComboboxSearch, but was able to find a workaround for that.

Thanks again man!

@ramiAbdou ramiAbdou changed the title fix: reset search after creating resource tag fix: reset search after creating resource tag 🏷️ Aug 20, 2024
@ramiAbdou ramiAbdou merged commit dde7962 into colorstackorg:main Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search isn't reset after creating resource tag 🔎
3 participants