-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: interview reviews base 🧱 #399
feat: interview reviews base 🧱 #399
Conversation
I decided to break up the feature into multiple PRs-it was getting too messy and this makes more sense. I'm curious if I should create stacked PRs and then not merge any until all the PRs are approved, or if I should just put the interview reviews feature behind a feature flag, so that way we can merge them in one at a time but it won't appear to members until the entire feature is complete. UPDATE: I went with putting the front-end changes behind a feature flag I also have a PR up for the next part (feat: add interview reviews). It's in my personal fork because it's stacked on top of this branch, but once this is merged I'll be able to move the PR to the main repo here. |
@@ -4,6 +4,7 @@ import { | |||
type SerializeFrom, | |||
} from '@remix-run/node'; | |||
import { generatePath, Link, useLoaderData } from '@remix-run/react'; | |||
import { useSearchParams } from '@remix-run/react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there is also useSearchParams
from @oyster/ui
here. Curious if this should be used here?
Going to close for now, and we'll revisit this in the future! |
Description ✏️
This PR implements the first part of the interview reviews feature.
It adds
interview_reviews
table to the databaseEmployees
,Company Reviews
, andInterview Reviews
on Companies page_profile.companies_.$id.tsx
behind a new feature flag namedinterview-reviews
Type of Change 🐞
Checklist ✅