Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: my first contribution 🚀 #381

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Conversation

Lumiho
Copy link
Contributor

@Lumiho Lumiho commented Jul 18, 2024

Description ✏️

Added name to CONTRIBUTORS.yml.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@tomas-salgado
Copy link
Collaborator

@Lumiho looks like there's a small formatting issue-the extra line needed at the end of the file was removed. Just add that back and this will be good to merge!

@Lumiho
Copy link
Contributor Author

Lumiho commented Jul 23, 2024

i think i fixed it now. Unsure though lol

Copy link
Collaborator

@tomas-salgado tomas-salgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So since you got the latest code from main into your branch, this restored the extra line at the end of the file, so in that case there's no need to add another one :)

For future reference you can see that the extra line was missing from the file because of the red circle that GitHub displays at the end of the file, you can see it here!

@ramiAbdou ramiAbdou changed the title chore - first contribution finally chore: my first contribution 🚀 Jul 24, 2024
@ramiAbdou ramiAbdou merged commit a3ae7f5 into colorstackorg:main Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants