Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove need for transpilation in db:seed 🌱 #10

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Conversation

ramiAbdou
Copy link
Member

@ramiAbdou ramiAbdou commented Mar 27, 2024

Description ✏️

Note: This PR does not solve the root issue and we need to figure out a more sustainable way to support transpilation in our non-Vite parts of the codebase.

This PR does the following:

  • Removes references to @colorstack/types and @colorstack/utils in the seed script.
  • Adds the top-level db:seed command, which references the core package command.
  • Updates the documentation for seeding according to the above.

Type of Change 🐞

  • Feature - A non-breaking change which adds functionality.
  • Fix - A non-breaking change which fixes an issue.
  • Refactor - A change that neither fixes a bug nor adds a feature.
  • Documentation - A change only to in-code or markdown documentation.
  • Tests - A change that adds missing unit/integration tests.
  • Chore - A change that is likely none of the above.

Checklist ✅

  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).
  • I have added/updated any relevant documentation (if applicable).

@ramiAbdou ramiAbdou self-assigned this Mar 27, 2024
@ramiAbdou ramiAbdou merged commit b37dd6c into main Mar 27, 2024
1 check passed
@ramiAbdou ramiAbdou deleted the rami/fix-seed branch March 27, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant