looks good

colorstackorg · Sep 17, 2024 · d431f3b · d431f3b
1 parent e1b73d9
commit d431f3b
Show file tree

Hide file tree

Showing 6 changed files with 247 additions and 61 deletions.
diff --git a/packages/core/src/infrastructure/bull/bull.types.ts b/packages/core/src/infrastructure/bull/bull.types.ts
@@ -486,6 +486,22 @@ export const SlackBullJob = z.discriminatedUnion('name', [
       id: true,
     }),
   }),
+  z.object({
+    name: z.literal('slack.profile_picture.changed'),
+    data: z.object({
+      profilePicture: Student.shape.profilePicture,
+      slackId: Student.shape.slackId.unwrap(),
+    }),
+  }),
+  z.object({
+    name: z.literal('slack.question.answer.private'),
+    data: z.object({
+      channelId: z.string().trim().min(1),
+      question: z.string().trim().min(1),
+      threadId: z.string().trim().min(1),
+      userId: z.string().trim().min(1),
+    }),
+  }),
   z.object({
     name: z.literal('slack.reaction.add'),
     data: SlackReaction.pick({
@@ -504,13 +520,6 @@ export const SlackBullJob = z.discriminatedUnion('name', [
       userId: true,
     }),
   }),
-  z.object({
-    name: z.literal('slack.profile_picture.changed'),
-    data: z.object({
-      profilePicture: Student.shape.profilePicture,
-      slackId: Student.shape.slackId.unwrap(),
-    }),
-  }),
   z.object({
     name: z.literal('slack.thread.sync_embedding'),
     data: z.object({

diff --git a/packages/core/src/modules/mixpanel.ts b/packages/core/src/modules/mixpanel.ts
@@ -53,6 +53,12 @@ export type MixpanelEvent = {
       | 'Resources';
   };
 
+  'Public Question Answered': {
+    '# of Threads Found': number;
+    Question: string;
+    Where: 'DM';
+  };
+
   'Resource Added': undefined;
   'Resource Link Copied': undefined;
   'Resource Tag Added': undefined;
@@ -66,7 +72,7 @@ export type TrackInput<Event extends keyof MixpanelEvent> = {
   event: Event;
   properties: MixpanelEvent[Event];
   request?: Request;
-  user: string;
+  user?: string;
 };
 
 export function track<Event extends keyof MixpanelEvent>({
@@ -83,8 +89,8 @@ export function track<Event extends keyof MixpanelEvent>({
   if (!request) {
     mixpanel.track(event, {
       ...properties,
+      ...(user && { distinct_id: user }),
       Application: application,
-      distinct_id: user,
     });
 
     return;
@@ -99,14 +105,14 @@ export function track<Event extends keyof MixpanelEvent>({
 
   mixpanel.track(event, {
     ...properties,
+    ...(user && { distinct_id: user }),
     Application: application,
     $browser: result.browser.name,
     $browser_version: result.browser.version,
     $device: result.device.model,
     $referrer: referrer,
     $os: result.os.name,
     $os_version: result.os.version,
-    distinct_id: user,
     ip,
   });
 }

diff --git a/packages/core/src/modules/notification/use-cases/send-slack-notification.ts b/packages/core/src/modules/notification/use-cases/send-slack-notification.ts
@@ -27,9 +27,11 @@ export async function sendSlackNotification(input: SendNotificationInput) {
 
   const channel = input.channel || ENV.INTERNAL_SLACK_NOTIFICATIONS_CHANNEL_ID;
 
-  await client.chat.postMessage({
+  const { ts } = await client.chat.postMessage({
     channel,
     text: input.message,
     thread_ts: input.threadId,
   });
+
+  return ts;
 }