fix: optional phone number has required behavior ❗️ (#526)

colorstackorg · Sep 26, 2024 · 2849453 · 2849453
1 parent 335c3f8
commit 2849453
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/types/src/domain/student.ts b/packages/types/src/domain/student.ts
@@ -12,7 +12,7 @@ import {
 } from './types';
 import { normalizeUri } from '../../../utils/src/index';
 import { type ExtractValue } from '../shared/types';
-import { NullishString } from '../shared/zod';
+import { EmptyStringToNull, NullishString } from '../shared/zod';
 
 // Enums
 
@@ -172,7 +172,7 @@ export const Student = Entity.merge(StudentSocialLinks)
       .string()
       .trim()
       .regex(/^\d{10}$/, 'Must be a 10-digit number.')
-      .optional(),
+      .or(EmptyStringToNull),
 
     /**
      * The preferred name that a member would like to go by. This will typically

diff --git a/packages/types/src/shared/zod.ts b/packages/types/src/shared/zod.ts
@@ -4,6 +4,8 @@ export const BooleanInput = z.preprocess((value) => {
   return typeof value === 'boolean' ? value : value === '1';
 }, z.boolean());
 
+export const EmptyStringToNull = z.literal('').transform(() => null);
+
 export const ISO8601Date = z.coerce.date().transform((value) => {
   return value.toISOString().split('T')[0];
 });