Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit some features #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Edit some features #8

wants to merge 2 commits into from

Conversation

jarrekk
Copy link

@jarrekk jarrekk commented Jan 29, 2017

Hi @cognitom ,

I have edited some places, maybe it will be helpful for you:

  1. At Paper sizes in paper.css, I make paper at middle of screen to make it looks better.
  2. I add class continuous to make paper display continuous if you want, so I can use wkhtmltopdf to make html page to pdf without page overflow.

Then I compress paper.css again.

Thanks

Copy link
Owner

@cognitom cognitom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JiaKunUp, thanks for you PR.
continuous seems good idea. I like it 😄

body.A4.landscape .sheet { width: 297mm; height: 209mm }
body.A5 .sheet { width: 148mm; height: 209mm }
body.A5.landscape .sheet { width: 210mm; height: 147mm }
body.A3 .sheet { width: 297mm; height: 419mm;margin-left: auto; margin-right: auto; }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the benefit of this. Could you pls explain it?
Anyway it seems better to write it in another line:

.sheet { margin-left: auto; margin-right: auto }

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cognitom Thanks for replying, if I add these, papers will be displayed at middle of screen like:
image
not on left side of screen, only looks good😁

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I write at this place to make paper displayed at center default. If you think this feature is optional write it in another line is OK.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have open an issue asking for centering the sheets as this PR. #20. I think centering the sheets is great for visual purpose for the clients/users a and I think it should be centered as default. I always for default center all the sheets using this:

.sheet {
     margin: 0 auto;
}

Think about MS Word, or any other printing tools. Sheets are centered for default. Centering sheets for print is like a standard for the clients/users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants