Updated infield standard config to latest changes #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronpal
commented
Aug 12, 2024
| skipOnVersionConflict: false | ||
| replace: true | ||
| nodes: | ||
| - space: cognite_app_data # should we have a separate space to avoid users overwriting config? |
There was a problem hiding this comment.
@danlevings I believe @erikangelsen-cognite had a concern regarding allowing users access to this space and the risk of corrupting the config
There was a problem hiding this comment.
Suggested change
| - space: cognite_app_data # should we have a separate space to avoid users overwriting config? | |
| - space: cognite_app_config_data | |
Talked to Dan and we want to add a new space for holding config data
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
| @@ -95,6 +95,6 @@ capabilities: | |||
| spaceIdScope: { | |||
| spaceIds: [ | |||
| 'cognite_app_data', # this space must be created to store user profile information | |||
There was a problem hiding this comment.
Suggested change
| 'cognite_app_data', # this space must be created to store user profile information | |
| 'cognite_app_data', # this space must be created to store user profile information | |
| 'cognite_app_config_data', # this space must be created to store config data |
| @@ -95,6 +95,6 @@ capabilities: | |||
| spaceIdScope: { | |||
| spaceIds: [ | |||
| 'cognite_app_data', # this space must be created to store user profile information | |||
There was a problem hiding this comment.
Suggested change
| 'cognite_app_data', # this space must be created to store user profile information | |
| 'cognite_app_data', # this space must be created to store user profile information | |
| 'cognite_app_config_data', # this space must be created to store config data |
| @@ -95,6 +95,6 @@ capabilities: | |||
| spaceIdScope: { | |||
| spaceIds: [ | |||
| 'cognite_app_data', # this space must be created to store user profile information | |||
There was a problem hiding this comment.
Suggested change
| 'cognite_app_data', # this space must be created to store user profile information | |
| 'cognite_app_data', # this space must be created to store user profile information | |
| 'cognite_app_config_data', # this space must be created to store config data |
There was a problem hiding this comment.
Also add it to the read only group, didnt have the option to suggest it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the change you have made.
Checklist
_version.py and
pyproject.toml per semantic versioning.