Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): search hook to consider data model version #4773

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

pramodcog
Copy link
Contributor

@pramodcog pramodcog commented Sep 26, 2024

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4651
https://cognitedata.atlassian.net/browse/BND3D-4597

Description 📝

While fetching datamodel search data, hook was returning data with latest version while would cause issue if application chooses specific version, this PR fixes issue by accepting datamodel version along with externalId & space.

And have also addressed, enabling point cloud model visibility when no CAD model is in the Scene, same for 360 Image as well.

How has this been tested? 🔍

In Search

Test instructions ℹ️

Yalc link to fusion repo and run Search application with cog-demo project

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@pramodcog pramodcog merged commit f4b8082 into master Sep 27, 2024
14 checks passed
@pramodcog pramodcog deleted the pramodcog/BND3D-4623 branch September 27, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants