Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-components): update model when geometry filter changed #4753

Merged

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Sep 12, 2024

Type of change

Bug

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Fix a bug where changing the geometryFilter input to the CadModelContainer would not update (remove/re-add) it correctly.

How has this been tested? 🔍

In Storybook (and a double-check for unnecessary removes in FDX). In CadModelContainer.stories.tsx in react-components, replace the bottom part of CadModelContainerStoryContent with this:

  const [geometryFilter, setGeometryFilter] = useState<GeometryFilter | undefined>({
    boundingBox: new Box3(new Vector3(-100, 0, -100), new Vector3(200, 10, 200)),
    isBoundingBoxInModelCoordinates: true
  });

  useEffect(() => {
    setTimeout(() => {
      setGeometryFilter(undefined);
      console.log('Set new geometry filter');
      setTimeout(() => {
        setGeometryFilter({
          boundingBox: new Box3(new Vector3(-100, 0, -100), new Vector3(200, 10, 200)),
          isBoundingBoxInModelCoordinates: true
        });
      }, 2000);
    }, 2000);
  }, []);

  // }, []);

  return (
    <>
      <CadModelContainer
        addModelOptions={{
          ...addModelOptions,
          geometryFilter: geometryFilter
        }}
        styling={styling}
        onLoad={onLoad}
      />
      <CadModelContainer
        addModelOptions={{ ...addModelOptions, geometryFilter: geometryFilter }}
        transform={transform}
        onLoad={onLoad}
      />
    </>
  );

Then, when running the Storybook, the model should first appeared a little clipped, then whole, then clipped again.

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

It's a miracle this worked before
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Sep 13, 2024
@haakonflatval-cognite haakonflatval-cognite merged commit a326ffe into master Sep 13, 2024
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/update-model-on-geometry-filter-change branch September 13, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants