-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): select single model simple list when has no scene #4746
base: master
Are you sure you want to change the base?
feat(react-components): select single model simple list when has no scene #4746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add few comments, will test the feature in a while!
react-components/src/components/RevealToolbar/SelectSingle3DModelButton.tsx
Outdated
Show resolved
Hide resolved
react-components/src/components/RevealToolbar/SelectSingle3DModelButton.tsx
Outdated
Show resolved
Hide resolved
react-components/src/components/RevealToolbar/SelectSingle3DModelButton.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to add storybook example.
…https://github.com/cognitedata/reveal into danpriori/BND3D-3961-select-single-model-simple-list
react-components/src/components/RevealToolbar/SelectSingle3DModelSelection.tsx
Outdated
Show resolved
Hide resolved
react-components/src/components/RevealToolbar/SelectSingle3DModelSelection.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on test!
Looks much better now, minor changes. I will test it tomorrow morning before I approve it
…1-select-single-model-simple-list
}; | ||
|
||
return ( | ||
<RevealContext sdk={sdk}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should the component be under RevealContext
?
As SelectSingle3DModelButton
is exported under RevealToolbar
which should be within RevealContext
, I do not think it is necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm strange. I only added because it was always complaining about without the context. Even under revealToolbar. Now is working without it.🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…1-select-single-model-simple-list
…fix the toggler when not selecting a single model
…1-select-single-model-simple-list
Type of change
Jira ticket 📘
BND3D-3961
https://cognitedata.atlassian.net/browse/
Description 📝
This feature is to give the option to select single 3d models CAD or PCs when doesnt have Scenes in the project.
It will shows up a globe icon on the left toolbar when has no scene created for the project and when is clicked, it will open a list of 3d models to select.
How has this been tested? 🔍
Tested with simulating the project with no scenes by forcing the flag "hasScene" being false (returned by the hook
useCheckIfHasScene
) in order to force the icon being show and list the 3d models available on the project to be selected, as no project without any scenes it was able to find and test it.Test instructions ℹ️
useCheckIfHasScene
hook)Note: this PR comes along with the PR in Fusion: https://github.com/cognitedata/fusion/pull/8080