Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime type checking POC #1554

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Runtime type checking POC #1554

wants to merge 2 commits into from

Conversation

erlendvollset
Copy link
Collaborator

  • Add beartype dependency
  • POC for runtime type checking

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.82%. Comparing base (b825dd8) to head (853611d).

Files with missing lines Patch % Lines
cognite/client/utils/_runtime_type_checking.py 72.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1554      +/-   ##
==========================================
- Coverage   90.86%   90.82%   -0.04%     
==========================================
  Files         130      131       +1     
  Lines       20153    20179      +26     
==========================================
+ Hits        18312    18328      +16     
- Misses       1841     1851      +10     
Files with missing lines Coverage Δ
cognite/client/exceptions.py 89.11% <100.00%> (+0.07%) ⬆️
cognite/client/utils/_runtime_type_checking.py 72.00% <72.00%> (ø)

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant