Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move artwork to a dedicated repository #35

Open
ranolfi opened this issue Feb 7, 2020 · 5 comments
Open

Move artwork to a dedicated repository #35

ranolfi opened this issue Feb 7, 2020 · 5 comments
Labels
meta: help wanted Extra attention is needed

Comments

@ranolfi
Copy link
Member

ranolfi commented Feb 7, 2020

Brought up a few times on Discord, met with no disagreement - artwork should be moved*

(*) For the sake of simplicity, I see no problem in maintaining an actual copy here instead of performing a strict "move" which would require a more complicated setup at this moment.

@manassehkatz
Copy link

Also select files from:

@mattjbrent
Copy link
Collaborator

@ranolfi can you clarify please - are we (re)moving from the stated directories or just copying so they exist in both places?

@mattjbrent mattjbrent added status: information needed Further information is requested meta: good first issue Good for newcomers labels Feb 12, 2020
@ranolfi
Copy link
Member Author

ranolfi commented Feb 12, 2020

@mattjbrent - from my POV doing an actual copy is good enough for now, just for the sake of having one "true source of truth" so to speak in terms of creative/brand assets, while still kickstarting this issue.

In the long term, I would recommend the git submodules approach (from annotated tags, ideally marked as releases btw) which can be "shallowly-cloned" or/and "sparse-checked out" to address concerns about history size (to be expected given a repo composed largely of binary content) and number of unrelated assets across parts of other projects, respectively. This would be the "more complicated setup" I mentioned in the issue description.

You can consult with other project members, particularly @kieranirving and JustinM (frontend group leader and devops leader, respectively) - but certainly with others too, to make a decision.

@mattjbrent mattjbrent pinned this issue Feb 25, 2020
@galegosimpatico
Copy link
Contributor

In the long term, I would recommend the git submodules approach [...] to address concerns about history size [...] and number of unrelated assets across parts of other projects, respectively. [...]

This is so right, thanks.

@galegosimpatico
Copy link
Contributor

No further question? -> can remove label status: information needed

Not a good first issue because requires creating a new repository, to be linked as submodule. Else (the repository exists) consider adding explaining which one is (could be https://github.com/codidact/artwork? but is empty yet).

@mattjbrent mattjbrent added meta: help wanted Extra attention is needed and removed meta: good first issue Good for newcomers status: information needed Further information is requested labels Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants