Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Project Logo Not Displaying on Project Github Page #44

Open
jflopezfernandez opened this issue Jan 30, 2020 · 3 comments
Open

Project Logo Not Displaying on Project Github Page #44

jflopezfernandez opened this issue Jan 30, 2020 · 3 comments

Comments

@jflopezfernandez
Copy link
Member

For some reason the project image isn't display correctly. When I click on the link that's being displayed instead, it takes me to a page containing only the following message:

Error Message

The image info also says the image is only fifteen bytes, so I'm not sure what's going on.

Image Details

@ranolfi
Copy link
Member

ranolfi commented Jan 30, 2020

This is why what I wrote on Discord last Monday is important:

@ozewski cc: @luap42 re: 4c51350

Was this change done in the GitHub UI?

Is there any way to commit the logo-codidact.png to an assets folder in the core repo and source it from there in the README?

What happened?

I merged codidact/landing-page/pull/30.

Repos should be self-containing, or use submodules (or subtrees) - judiciously. If we go with the latter approach, a dedicated repo for assets/artwork is in order.

@ranolfi
Copy link
Member

ranolfi commented Feb 7, 2020

Quick fix: Reference a release tag, but never master: https://raw.githubusercontent.com/codidact/landing-page/live/2020-01-07T2316Z/source-assets/img/logo-codidact.png.

Proper fix: copy the asset to this repo and source it from here instead.

FYI, future assets source should be in the artwork repo. Re: codidact/landing-page#35

@luap42
Copy link
Member

luap42 commented Feb 9, 2020

FYI, future assets source should be in the artwork repo. Re: codidact/landing-page#35

I think this should be the best solution. The files in the artwork repo would almost never change, hence this seems to be a stable solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants