allow viewing user detail without auth

codekeyz · Jan 6, 2024 · 343cfa3 · 343cfa3
1 parent 86164a9
commit 343cfa3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/lib/app/providers/provide_routes.dart b/lib/app/providers/provide_routes.dart
@@ -16,8 +16,11 @@ class RouteServiceProvider extends ServiceProvider {
           Route.post('/auth/login', (AuthController, #login)),
           Route.post('/auth/register', (AuthController, #register)),
 
-          // get articless and detail without auth
-          Route.group('/articles').routes([
+          /// get user detail without auth
+          Route.get('/users/<userId>', (UserController, #show)),
+
+          /// get articles and detail without auth
+          Route.group('articles').routes([
             Route.get('/', (ArticleController, #index)),
             Route.get('/<articleId>', (ArticleController, #show)),
           ]),

diff --git a/lib/app/routes/api.dart b/lib/app/routes/api.dart
@@ -6,7 +6,6 @@ List<RouteDefinition> routes = [
   Route.group('users').routes([
     Route.get('/', (UserController, #index)),
     Route.get('/me', (UserController, #currentUser)),
-    Route.get('/<userId>', (UserController, #show)),
   ]),
 
   /// Articles

diff --git a/test/backend_test.dart b/test/backend_test.dart
@@ -407,12 +407,12 @@ void main() {
               .test();
         });
 
-        test('should return user for /users/<userId> ', () async {
+        test('should return user for /users/<userId> without auth', () async {
           final randomUser = await DB.query<User>().get();
           expect(randomUser, isA<User>());
 
           await (await server.tester)
-              .get('$usersApiPath/${randomUser!.id!}', headers: {HttpHeaders.cookieHeader: authCookie!})
+              .get('$usersApiPath/${randomUser!.id!}')
               .expectStatus(HttpStatus.ok)
               .expectHeader(HttpHeaders.contentTypeHeader, 'application/json; charset=utf-8')
               .expectBodyCustom((body) => jsonDecode(body)['user'], randomUser.toPublic)