Support Contao mono repo

[fritzmg]

When using the Contao mono repo the following error might occur:

TypeError:
version_compare(): Argument #1 ($version1) must be of type string, null given

  at vendor\codefog\contao-haste\src\Form\Form.php:929
  at version_compare(null, '5.0', '>=')
     (vendor\codefog\contao-haste\src\Form\Form.php:929)

This PR fixes that by allowing to fall back to the mono repo if contao/core-bundle is not found.

[aschempp]

Shouldn't Composer return the version of a package that is provided by another package?

[aschempp]

I mean that sounds like something that should be fixed in Composer instead? 🤔
/cc @Toflar

[Toflar]

Why would Composer care about how you build your monorepos?

[aschempp]

It's not about monorepo. It's about the fact that we check for a version of a package, but the package has been replaced by another one. So I would expect to get the version of the replacing package.

[aschempp]

Or maybe there is a way to find the "final" package to check that version? 🤔

[Toflar]

No idea 🤷‍♂️ I think the PR looks correct (will still not work with dev branches but that's what it is).

[fritzmg]

(will still not work with dev branches but that's what it is)

The package name of a dev branch will still be contao/contao.

[Toflar]

There will be no version.

[fritzmg]

True. I think we can change the check altogether.

[aschempp]

No idea 🤷‍♂️ I think the PR looks correct (will still not work with dev branches but that's what it is).

This PR works, because the author of this extension assumes to have either of those packages installed. But if contao/core-bundle is replaced by foobar/core-bundle fork, it will not longer work either.

[fritzmg]

@qzminski the check was added in 25b2f0e - but what is the reason behind it? Shouldn't this also apply in Contao 4.13?

[qzminski]

The problem is with the file uploads. They have been reworked by @Toflar in Contao 5 and there is no longer $_SESSION['FILES'], but now they are returned as the widget's value. In Contao core it changed here: https://github.com/contao/contao/blob/5.x/core-bundle/contao/forms/Form.php#L273

[fritzmg]

Yes but the method returns $widget->value in any case:

contao-haste/src/Form/Form.php

Lines 928 to 939 in 25b2f0e

	// Support file uploads in Contao 5
	if (version_compare(InstalledVersions::getVersion('contao/core-bundle'), '5.0', '>=') && $widget instanceof UploadableWidgetInterface) {
	return $widget->value;
	}
	if (!$widget->submitInput()) {
	// Do not throw exception here for BC
	return null;
	}
	return $widget->value;
	}

$widget->submitInput() should return true (unless the widget is disabled or readonly).

[qzminski]

That's exactly the problem: https://github.com/contao/contao/blob/5.x/core-bundle/contao/forms/FormUpload.php

The upload field does not have the $blnSubmitInput = true.

[fritzmg]

Right, but then we can still remove the version check, can we not? Because:

if ($widget instanceof UploadableWidgetInterface) { 
    return $widget->value; 
} 

• This will return null in Contao 4.13, since the FormFileUpload widget does not hold the value.
• It will return the value in Contao 5

[qzminski]

Theoretically yes. I think that would be the appropriate fix. @Toflar what do you think?

[Toflar]

If it works, it's the appropriate fix :D

[qzminski]

I have just released it as 5.1.14, thank you @fritzmg !