Implementing (approximately) fulltext search #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Searches all fields for query terms in any order. - Attempts to rank more relevant foods first.
jesserosato
added a commit
that referenced
this pull request
Jan 25, 2015
Implementing (approximately) fulltext search
|
@donmccurdy Thank you! Really nicely done, very concise. I'll close #13 and open a new issue for client-side UI to support this. Again, thanks for contributing! |
|
OST, @donmccurdy I'm gonna keep #13 open as a place for discussion on the feature in general, and we'll spin up new issues as needed for more specific tasks as they arise. |
|
Sure thing, sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't sure where help would be most useful to you all, but this at least partially addresses #13.
If you need more performance there are some lightweight options like Sphinx Realtime indexes, but for the dataset in the repository this seems to work nicely.