Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet adapter v 0.1 #194

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Wallet adapter v 0.1 #194

wants to merge 2 commits into from

Conversation

Sharathxct
Copy link


Wallet Adapter

This pull request adds two new directories to the dev branch ( adapter, react-dapp ) and adds a new route in the wallet app /connection which will trigger by the react-dapp through the adapter which enables connection between the dapps and the web wallet.

🛠️ Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🚨 Breaking change
  • 📚 Documentation update

✅ Checklist

To ensure a smooth review process, please check off each item as you complete it:

  • [ ✅ ] Code Style: My code adheres to the project’s style guidelines.
  • [ ✅ ] Self-Review: I have reviewed my own code and made improvements.
  • [ ✅ ] Comments: I’ve added comments to explain complex or non-obvious parts of the code.
  • [ ✅ ] Documentation: I’ve updated the documentation to reflect my changes.
  • [ ✅ ] Warnings: My changes introduce no new warnings.
  • [ ✅ ] Tests: I’ve added tests to verify that my changes work as expected.
  • [ ✅ ] Passes Locally: All new and existing unit tests pass on my local machine.

🎥 Video

adapterDemo.mp4

We appreciate your contributions! If you have any questions or need further assistance, feel free to reach out.

@Sharathxct
Copy link
Author

@rahulbarmann can you please connect with me whenever you are free to help me setup kms...

@rahulbarmann
Copy link
Contributor

@Sharathxct Sure man, I hope now it works fine

@cb7chaitanya
Copy link
Collaborator

@Sharathxct I will continue my review sifting through the files over specifics, but one thing is why have you added a react dapp to the repository just for testing, you can just use npm link and test the package out in another repository locally, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants