Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the spinner until the session get's the image #189

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

Ameerjafar
Copy link
Contributor

@Ameerjafar Ameerjafar commented Sep 20, 2024


Pull Request Title

2024-09-23.19-09-58.mp4

Issue Number: Fixes #172

πŸ› οΈ Type of Change

  • [βœ…] πŸ› Bug fix
  • ✨ New feature
  • 🚨 Breaking change
  • πŸ“š Documentation update

βœ… Checklist

To ensure a smooth review process, please check off each item as you complete it:

  • [βœ…] Code Style: My code adheres to the project’s style guidelines.
  • [βœ…] Self-Review: I have reviewed my own code and made improvements.
  • [βœ…] Comments: I’ve added comments to explain complex or non-obvious parts of the code.
  • [βœ…] Documentation: I’ve updated the documentation to reflect my changes.
  • [βœ…] Warnings: My changes introduce no new warnings.
  • [βœ…] Tests: I’ve added tests to verify that my changes work as expected.
  • [βœ…] Passes Locally: All new and existing unit tests pass on my local machine.

We appreciate your contributions! If you have any questions or need further assistance, feel free to reach out.

@Ameerjafar
Copy link
Contributor Author

@cb7chaitanya if anything i wanted to do in this pr let me know?

@Ameerjafar Ameerjafar changed the title Session Added the spinner until the session get's the image Sep 20, 2024
@cb7chaitanya
Copy link
Collaborator

Please provide a screen recording of what you changed

@Ameerjafar
Copy link
Contributor Author

@cb7chaitanya i have added the video

@cb7chaitanya
Copy link
Collaborator

Skeletons might look better, please try adding skeletons here rather than a spinner @Ameerjafar

@Ameerjafar
Copy link
Contributor Author

@cb7chaitanya working on that.

@Ameerjafar
Copy link
Contributor Author

Ameerjafar commented Sep 23, 2024

@cb7chaitanya i have added the skeleton loading and I took the reference from this pr #188 i have the updated the video as well

@cb7chaitanya cb7chaitanya merged commit 598fde2 into code100x:dev Sep 23, 2024
1 check passed
@cb7chaitanya
Copy link
Collaborator

Merged it @Ameerjafar

@Ameerjafar Ameerjafar deleted the session branch September 24, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Appbar rendering issue
2 participants