Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Autoplay the next video after completion of one #1308 #1434

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SahilLamba0008
Copy link

PR Fixes:

  • 1 Autoplay Next Video: Implemented functionality to autoplay the next video after one completes.
  • 2 Minor Code Cleanup: Refactored some code related to the video player to ensure smooth transitions between videos.

Resolves #[Issue Number if there]

Screen.Recording.2024-10-05.at.5.50.26.PM.mp4

Checklist before requesting a review

  • [ ✅ ] I have performed a self-review of my code
  • [ ✅ ] I assure there is no similar/duplicate pull request regarding same issue

@devsargam
Copy link
Collaborator

Adding it to things to reivew

@devsargam
Copy link
Collaborator

Mean while if u can clear the conflicts @

@SahilLamba0008
Copy link
Author

Mean while if u can clear the conflicts @

I've resolved the conflicts in the PR, Please review and let me know if there are any other changes needed.

@Prashant-flick
Copy link
Contributor

Prashant-flick commented Oct 9, 2024

@SahilLamba0008
I think this will only work in the week in which the video is playing , it will not play the next week video, when you are at the last video of a week, can you fix that

@SahilLamba0008
Copy link
Author

@Prashant-flick @devsargam
Thank you for the feedback! While I understand the request to have videos automatically continue into the next week's module, I believe this approach may unnecessarily increase the load, especially since not all users may be ready to proceed to the next week's content right away.

Instead, I propose implementing a modal at the end of the last video in the current week's module, similar to YouTube's playlist behavior. This modal could prompt users with an option like "Continue to next week's videos" (refer to image for more context), giving them control over when they want to move forward. This would provide a smoother user experience and reduce potential server or client load by avoiding preloading content until the user chooses to proceed.

Let me know if this sounds like a good compromise!

Screenshot 2024-10-09 at 3 53 46 PM

@SahilLamba0008
Copy link
Author

@Prashant-flick @devsargam Thank you for the feedback! While I understand the request to have videos automatically continue into the next week's module, I believe this approach may unnecessarily increase the load, especially since not all users may be ready to proceed to the next week's content right away.

Instead, I propose implementing a modal at the end of the last video in the current week's module, similar to YouTube's playlist behavior. This modal could prompt users with an option like "Continue to next week's videos" (refer to image for more context), giving them control over when they want to move forward. This would provide a smoother user experience and reduce potential server or client load by avoiding preloading content until the user chooses to proceed.

Let me know if this sounds like a good compromise!

Screenshot 2024-10-09 at 3 53 46 PM

@devsargam should I create a issue for this and implement it ?

@devsargam
Copy link
Collaborator

@SahilLamba0008 whatever you are thinking is somewhat correct but I would need a bit more context
Can you share a loom https://www.loom.com/ with your explanation

@SahilLamba0008
Copy link
Author

@SahilLamba0008 whatever you are thinking is somewhat correct but I would need a bit more context Can you share a loom https://www.loom.com/ with your explanation

check this out ( https://www.loom.com/share/5be7066dc3ac4d81b1b1a7f7df72b7ae?sid=401e93af-557b-4e43-8c6c-1defd395dc84 ). I'm suggesting to add a modal just like udemy does, suggesting next weeks content on completion of the last video of current week. This modal can have text as Up Next and Next Weeks Module Name with a play button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Autoplay the next video after completion of one
3 participants